search

CFenner / MMM-AirQuality

A module for the MagicMirror to display a location's air quality index.
MIT License
35 stars 15 forks source link

Add header feature #12

Closed cslev closed 2 years ago

cslev commented 2 years ago

Minor design update to be more in line with other modules with headers, e.g., weather module. Let me know what you think!

Cheers

CFenner commented 2 years ago

@cslev isn't this already supported by the module framework? see https://docs.magicmirror.builders/modules/configuration.html#module-configuration

Bildschirmfoto 2021-12-23 um 20 05 47
CFenner commented 2 years ago

Thanks for the contribution, but I think the default header functionality is good enough.

We could think of adding a appendLocationNameToHeader flag, like it's implemented here.

cslev commented 2 years ago

Hi @CFenner , sorry for the late reply. I was playing around with the header configuration of the default framework, but could not put the location info there, only the AirQuality header could have been disabled/enabled. Hence, I added the feature. Sorry if it was already part of the whole system, and I was blind realizing how to get it working :) I had to spare space on my mirror, and every bits counted :D

Thanks