search

CGAL / cgal-swig-bindings

CGAL bindings using SWIG
Other
346 stars 93 forks source link

Fix for windows #132

Closed maxGimeno closed 4 years ago

maxGimeno commented 4 years ago

In header only, the macro CGAL_DLL_EXPORT(IMPORT) is defined empty. In swig, the exports for the cpp targets use this macro, so no .lib is generated if we configured CGAL as header only. To fix that, I introduced two new macros: SWIG_CGAL_IMPORT and SWIG_CGAL_EXPORT, same as the original versions, but not empty in header only mode. This way the linking problems on windows are gone.

lrineau commented 4 years ago

Is the patch sufficient to run ctest tests on Windows?

maxGimeno commented 4 years ago

Now it is, at least on Blake.

lrineau commented 4 years ago

The next step will be to add a testsuite on Windows.

It seems that is doable on Travis: https://docs.travis-ci.com/user/languages/python/#running-python-tests-on-multiple-operating-systems