search

CGAL / cgal-swig-bindings

CGAL bindings using SWIG
Other
346 stars 93 forks source link

Discuss: Adding Shape_detection_3 #138

Closed thopiekar closed 4 years ago

thopiekar commented 4 years ago

As there was no reply on #131, I would like to share some code. My colleague managed to get that far, but we are still facing memory leaks and it still doesn't work perfectly well.

Hereby I would like to kindly ask for some review and any feedback or help would be highly appreciated.

Eventually, @CodyFagley might find some time and give further details here.

Fixes #131

lrineau commented 4 years ago

Could you please add an example, so that one can see the API, and have the code automatically tested by our CI?

thopiekar commented 4 years ago

@lrineau Sure. I will prepare it in the following days. I'll let you know when I'm done.

thopiekar commented 4 years ago

@lrineau I just created a new PR and cleaned up the branch, so we can continue working. Let's continue discussing there.