CGAL / cgal-swig-bindings

CGAL bindings using SWIG
Other
338 stars 92 forks source link

Separate wheel building and testing #262

Closed SaillantNicolas closed 4 months ago

SaillantNicolas commented 5 months ago

the wheel test is now in another job.

lrineau commented 5 months ago

That creates a nice drawing of the graph of jobs, at https://github.com/CGAL/cgal-swig-bindings/actions/runs/7627051759?pr=262

Screenshot_20240123_152530

lrineau commented 5 months ago

The Github actions will fail on Windows and MacOS, because of the upgrade to SWIG 4.2. @sloriot might come up with a proposal for a fix, eventually.

lrineau commented 5 months ago

@SaillantNicolas:

I have fixed the CI in main (https://github.com/CGAL/cgal-swig-bindings/pull/263), and merge back main here. And also two improvements: 86efe525984cd43deba157c4e1fd135782bddbb8 and d210b995cd155711584c3c25980d0a572c2bf61a.

Now there are two issues:

See https://github.com/CGAL/cgal-swig-bindings/actions/runs/7654331055

lrineau commented 5 months ago

On Windows, we should use https://pypi.org/project/delvewheel/ to "fix" the wheel (like auditwheel on Linux and delocate on macOS).

Or maybe use https://github.com/jvolkman/repairwheel on all three platforms.