search

CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.96k stars 1.38k forks source link

BGL copy_face_graph use deprecated code? #1033

Closed lrineau closed 8 years ago

lrineau commented 8 years ago

It seems I have merged #728 too soon. The code fails to compile with -DCGAL_NO_DEPRECATED_CODE:

https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.9-Ic-28/BGL/TestReport_lrineau_Ubuntu-Latest-NO_DEPRECATED_CODE.gz

lrineau commented 8 years ago

Cc: @afabri @sloriot

sloriot commented 8 years ago

Where is this file coming from? I don't see it in master

sloriot commented 8 years ago

From afabri/BGL-copy_face_graph

sloriot commented 8 years ago

I close the issue since it refers to a branch not merged in master.

lrineau commented 8 years ago

The bug is probably in copy_face_graph, from PR #728, merged in master. Andreas just added a test of that function.

sloriot commented 8 years ago

I bet this is a missing include (Polyhedron_3.h is not including graph_traits_Polyhedron_3.h when not using deprecating code).

afabri commented 8 years ago

just fixed it. In fact we do not have a testsuite for this function. And I mainly wrote it as we have an ICE with an old VC++ in the skeletonization testsuite.

lrineau commented 8 years ago

That is strange that the compilation error was only with the platform with -DCGAL_NO_DEPRECATED_CODE.