search

CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.99k stars 1.39k forks source link

BGL tests : compilation error with recent OpenMesh #1360

Closed janetournois closed 8 years ago

janetournois commented 8 years ago

I am now using OpenMesh-6.2 and I get the following error when I compile the test graph_concept_OpenMesh.cpp inside the BGL package.

The error is the following :

CGAL\cgal-dev\STL_Extension\include\CGAL/hash_openmesh.h(31): error C2084: the function 'size_t OpenMesh::hash_value(const OpenMesh::BaseHandle &)' already has a body in C:\3rdPartyLibs\OpenMesh-6.2\include\OpenMesh/Core/Mesh/Handles.hh(110)

We should take into account the version number to define this function or not

lrineau commented 8 years ago

@sloriot @afabri This issue is selected for the milestone 4.8.2. Do we have the resources to work on it rather soon? Once the branch for CGAL-4.9 is created, it will be difficult to maintain the branch for CGAL-4.8.2.

lrineau commented 8 years ago

Actually, I found out that <CGAL/hash_openmesh.h> is a file that was added to CGAL-4.9, and was not in CGAL-4.8.x. I have re-assigned the bug to 4.9 instead of 4.8.2.

lrineau commented 8 years ago

Fixed by #1377.