search

CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.86k stars 1.38k forks source link

New runtimes errors of Segment_Delaunay_graph_2 with recent compilers #2479

Open lrineau opened 6 years ago

lrineau commented 6 years ago

Issue Details

A lot of test and examples of Sdg_2 have runtime errors, in the recent Fedora testsuite, with g++-7.2.1:

https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.12-I-54/Segment_Delaunay_graph_2_Examples/TestReport_lrineau_Fedora-Release.gz

------------------------------------------------------------------
- ProgramOutput.sdg-count-sites.Fedora-Release
------------------------------------------------------------------
CGAL::Random()::get_seed() = 1506928648
SDGDS is ok... Segment Delaunay graph is NOT valid...sdg-count-sites: 
[...]/sdg-count-sites.cpp:32: int main(): Assertion `sdg.is_valid(true, 1)' failed.
./cgal_test_with_cmake: line 70: 24932 Aborted                 (core dumped) ./sdg-count-sites

Environment

sgiraudot commented 6 years ago

I can't reproduce it using g++-7 on Debian (but the provided version is 7.2.0-8, not 7.2.1, that might be the reason why).

lrineau commented 6 years ago

I can reproduce the issue on my Fedora.

lrineau commented 6 years ago

On my Fedora 26, I can reproduce, on the program sdg-count-sites with:

but not with

lrineau commented 6 years ago

I have also tried with:

and in both case the program compiles and runs fine.

lrineau commented 6 years ago

I do not know how to debug that code. I give up for the moment.

MaelRL commented 4 years ago

Do you remember where did you set the seed in the code ?

Incidentally (@maxGimeno), the printing of the seeds at the start of the program output seems gone from some packages, see for example: https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.1-Ic-53/Segment_Delaunay_graph_2_Examples/TestReport_lrineau_Fedora-Release.gz. Is that normal?

lrineau commented 4 years ago

Incidentally (@maxGimeno), the printing of the seeds at the start of the program output seems gone from some packages, see for example: cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.1-Ic-53/Segment_Delaunay_graph_2_Examples/TestReport_lrineau_Fedora-Release.gz. Is that normal?

Actually, the printing of the seed seems to be removed when CGAL_HEADER_ONLY is defined. Now that it is the default, since CGAL-5.0, only the rare platforms with CGAL_NO_HEADER_ONLY will display the seed. See: https://github.com/CGAL/cgal/blob/eb9b8e6c52c2ccaace56e977f7e43a6702a6b382/Random_numbers/include/CGAL/Random.h#L233-L242

afabri commented 2 years ago

I am wondering if the PR #6265 solves this issue.