search

CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.9k stars 1.38k forks source link

Minkowski_sum_2 contains a fork of AABB Tree #272

Open lrineau opened 9 years ago

lrineau commented 9 years ago

Minkowski_sum_2/include/CGAL/Minkowski_sum_2/AABB_tree_with_join.h

For maintenance reasons, we should merge the two implementations!

sgiraudot commented 8 years ago

@efifogel and @mhsaar, you are the 2 maintainers of the package Minkowski_sum_2: is there a reason why a fork of AABB_tree was used? Is it possible to merge it back into the AABB_tree package or is the fork really going in different directions?

efifogel commented 8 years ago

The code in the Minkowski_sum_2 package supports 2D AABB trees, while (as far as I know) CGAL has only one package that handles AABB trees and it's in 3D. Besides, and Michael knows more about this than I, the 2D version in the Minkowski_sum_2 package supports functionality the generalization of which to 3D is not supported by the 3D AABB package. In summary, the introduction of 2D AABB package and enhancing the 3D AABB packages are jobs to be done...

//) o /__ // (__ ( ( ( (/ (/-(-'(/ /

On Wed, Aug 10, 2016 at 11:35 AM, Simon Giraudot notifications@github.com wrote:

@efifogel https://github.com/efifogel and @mhsaar https://github.com/mhsaar, you are the 2 maintainers of the package Minkowski_sum_2: is there a reason why a fork of AABB_tree was used? Is it possible to merge it back into the AABB_tree package or is the fork really going in different directions?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CGAL/cgal/issues/272#issuecomment-238801303, or mute the thread https://github.com/notifications/unsubscribe-auth/AGoWuMzypoR7MfiFByP56PVEj9xy2ufbks5qeY1ggaJpZM4FraNv .