General kernel support in Mesh_skeletonization

CGAL / cgal

The public CGAL repository, see the README below

https://github.com/CGAL/cgal#readme

Other

4.96k stars 1.38k forks source link

General kernel support in Mesh_skeletonization #3024

Closed riaqn closed 6 years ago

riaqn commented 6 years ago

Issue Details

Currently there are some uses of double in the code of Mesh_skeletonization, making it impossible to use kernel other than inexact ones.

Environment

Operating system (Windows/Mac/Linux, 32/64 bits): Linux 64bit
Compiler: gcc 7.3.1
Release or debug mode: release
Specific flags used (if any):
CGAL version: 4.11
Boost version:1.66.0
Other libraries versions if used (Eigen, TBB, etc.):

sloriot commented 6 years ago

Are you simply reporting a documentation error or are you really interested in having the code working on points from an exact construction kernel? In the latter case, what do you expect to get compared to using floating point?

riaqn commented 6 years ago

Hi @sloriot thanks for the reply.

I don't know - I was using it to contract a mesh(for only once) and while the source mesh is free of self-intersection, the meso_skeleton() is not. So I assume it might have to do with the exact-ness.

sloriot commented 6 years ago

The meso-skeleton is by construction not guaranteed to be free from self-intersect. The only guarantee you have is that it has the same topology as the input mesh.

riaqn commented 6 years ago

I see. I know it's totally off-the-topic, but do you know if there is anything I can do to achieve the same goal? namely, contract a mesh such that it contracts less on vertices with higher mean curvature, and vice versa, and keep the output mesh free of self-intersection.

sloriot commented 6 years ago

I don't think we have anything like that in CGAL for now.