CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.99k stars 1.39k forks source link

The dynamic_property_maps have no name #4162

Closed maxGimeno closed 4 years ago

maxGimeno commented 5 years ago

Issue Details

The dynamic-property_maps, if used on a surface_mesh, will internally call the Surface_mesh::add_property() function. The problem is that a dynamic_property_map has no name parmeter to forward to the surface_mesh, which makes it impossible to retrieve the property once added.

I propose either :

That would help to BGLize the read_off() functions, within the scope of the reorganization of the CGAL IO functions.

@CGAL/geometryfactory what do you think ?

sloriot commented 5 years ago

What's the issue? it has an auto removal feature so why would you like to retrieve it? You are not supposed to lose the reference over it.

maxGimeno commented 5 years ago

What is the point of using the surface_mesh mechanism as an internal mechanism then ?

sloriot commented 5 years ago

You are supposed to keep the reference over the map otherwise it will be deleted.

MaelRL commented 4 years ago

Seems like this feature request is invalid ? @maxGimeno @sloriot

sloriot commented 4 years ago

Again I'm not sure to understand the question, but if I understand it correctly then it should be closed :)

afabri commented 4 years ago

Max Lyon told me that in OpenMesh they introduce with 8.1 a PropertyManager, and properties without name that get deleteted when the property handle goes out of scope. It is maybe easier to discuss this the next time @sloriot is at GF. See the doc of their daily build.

maxGimeno commented 4 years ago

I don't need this anymore and don't remember why I said that. Probably I didn't understand how to use the dyamic properties. I think this issue can be closed now.