orient_polygon_soup BUG

[simonasdmd]

Please use the following template to help us solving your issue.

Issue Details

When I simplify the triangulation Entering this function does not exit Caton

Source Code

Environment

• Operating system (Windows/Mac/Linux, 32/64 bits):windows 10
• Compiler: vs2017
• Release or debug mode:release
• Specific flags used (if any):
• CGAL version:5.0
• Boost version:1.7
• Other libraries versions if used (Eigen, TBB, etc.):

[sloriot]

Could you please provide the points + the faces so that we can try to reproduce the issue?

Side note: you are passing the vector of points and faces by copy and not by reference (which means that they are copied when calling the function).

[simonasdmd]

hi~ @sloriot this is my data: Tile_0_22.zip

[simonasdmd]

hello~ anybody here~ i need help from

[sloriot]

We had troubles reading your file so it took some time. You can call the function repair_polygon_soup() before calling orient and it should work.

[simonasdmd]

@sloriot thanks~ it‘s work It helped me a lot If you can. Can you tell me what caused it.

[sloriot]

The soup was not valid (degenerate elements IIRC).

[simonasdmd]

@sloriot hi ,I revised it as you said, but there are still problems. Zip contains the original data and the simplified data. Please help me see where I still need to change. test data： Tile_1.zip screenshot：

[simonasdmd]

hi~ @sloriot @lrineau SMS::Count_ratio_stop_predicate stop(0.3); When I set it to 0.3, it will be like this。

I think we can judge the concept of "minimum" internally. For example, according to normal conditions. A model consists of 10000 triangles. He's reduced to 30% and should be able to maintain geometry. But some special models. For example, it's big or complicated. Geometry cannot be maintained below 6000. But users can't judge whether they should use 0.6 or 0.3. Can they add some judgments?

[sloriot]

It is impossible to understand what problem you have if you don't explain what problem you are having. This issue is about soup -> mesh and then you are talking about the simplification package. The best way to show a problem is to provide a minimal example that we can run and that show the problem.