Bundle CGAL 3D demo error

kikislater commented 2 years ago

Bundle CGAL 3D demo error doesn't build

Issue Details

CMake error :

$ docker run --rm -v $PWD/results:/results:Z -v /home/sylvain/build/cgal-5.4/:/cgal:ro docker.io/cgal/bundle-3d-demo  /scripts/build.sh -j6 && /scripts/deploy.sh 
== CMake setup ==
-- The CXX compiler identification is GNU 7.3.1
-- The C compiler identification is GNU 7.3.1
-- Check for working CXX compiler: /opt/rh/devtoolset-7/root/usr/bin/c++
-- Check for working CXX compiler: /opt/rh/devtoolset-7/root/usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: /opt/rh/devtoolset-7/root/usr/bin/cc
-- Check for working C compiler: /opt/rh/devtoolset-7/root/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
== CMake setup (DONE) ==

-- Build CGAL from n/a-branch: n/a
-- Removed not-a-package: .clang-tidy;.gitattributes;.github;.gitignore;CGALConfig.cmake;CGALConfigVersion.cmake;Data;Documentation;INSTALL.md;LICENSE.md;Miscellany;README.md;ccpp.yml;cmake_uninstall.cmake.in
-- Installation package directory: /cgal/Installation
-- Maintenance package directory: /cgal/Maintenance
-- Core package directory: /cgal/Core
-- Packagenames: AABB_tree;Advancing_front_surface_reconstruction;Algebraic_foundations;Algebraic_kernel_d;Algebraic_kernel_for_circles;Algebraic_kernel_for_spheres;Alpha_shapes_2;Alpha_shapes_3;Apollonius_graph_2;Arithmetic_kernel;Arrangement_on_surface_2;BGL;Barycentric_coordinates_2;Boolean_set_operations_2;Bounding_volumes;Box_intersection_d;CGAL_Core;CGAL_ImageIO;CGAL_ipelets;Cartesian_kernel;Circular_kernel_2;Circular_kernel_3;Circulator;Classification;Combinatorial_map;Cone_spanners_2;Convex_decomposition_3;Convex_hull_2;Convex_hull_3;Convex_hull_d;Distance_2;Distance_3;Envelope_2;Envelope_3;Filtered_kernel;Generalized_map;Generator;GraphicsView;HalfedgeDS;Hash_map;Heat_method_3;Homogeneous_kernel;Hyperbolic_triangulation_2;Inscribed_areas;Installation;Interpolation;Intersections_2;Intersections_3;Interval_skip_list;Interval_support;Jet_fitting_3;Kernel_23;Kernel_d;LEDA;Linear_cell_complex;MacOSX;Maintenance;Matrix_search;Mesh_2;Mesh_3;Mesher_level;Minkowski_sum_2;Minkowski_sum_3;Modifier;Modular_arithmetic;Nef_2;Nef_3;Nef_S2;NewKernel_d;Number_types;OpenNL;Optimal_bounding_box;Optimal_transportation_reconstruction_2;Optimisation_basic;Orthtree;Partition_2;Periodic_2_triangulation_2;Periodic_3_mesh_3;Periodic_3_triangulation_3;Periodic_4_hyperbolic_triangulation_2;Point_set_2;Point_set_3;Point_set_processing_3;Poisson_surface_reconstruction_3;Polygon;Polygon_mesh_processing;Polygonal_surface_reconstruction;Polyhedron;Polyline_simplification_2;Polynomial;Polytope_distance_d;Principal_component_analysis;Principal_component_analysis_LGPL;Profiling_tools;Property_map;QP_solver;Random_numbers;Ridges_3;STL_Extension;Scale_space_reconstruction_3;Scripts;SearchStructures;Segment_Delaunay_graph_2;Segment_Delaunay_graph_Linf_2;Set_movable_separability_2;Shape_detection;Shape_regularization;Skin_surface_3;Snap_rounding_2;Solver_interface;Spatial_searching;Spatial_sorting;Straight_skeleton_2;Stream_lines_2;Stream_support;Subdivision_method_3;Surface_mesh;Surface_mesh_approximation;Surface_mesh_deformation;Surface_mesh_parameterization;Surface_mesh_segmentation;Surface_mesh_shortest_path;Surface_mesh_simplification;Surface_mesh_skeletonization;Surface_mesh_topology;Surface_mesher;Surface_sweep_2;TDS_2;TDS_3;Testsuite;Tetrahedral_remeshing;Three;Triangulation;Triangulation_2;Triangulation_3;Triangulation_on_sphere_2;Union_find;Visibility_2;Voronoi_diagram_2;Weights
== Setting paths (DONE) ==

== Generate version files ==
-- CGAL_VERSION is 5.4-I-900
-- CGAL_VERSION_NR is 1050400900
-- CGAL_GIT_HASH is 
-- CGAL_CREATED_SVN_REVISION is 99999 (dummy)
-- CGAL_MAJOR_VERSION=5
-- CGAL_MINOR_VERSION=4
-- CGAL_BUGFIX_VERSION=0
-- CGAL_BUILD_VERSION=900
-- Targetting Unix Makefiles
-- Using /opt/rh/devtoolset-7/root/usr/bin/c++ compiler.
-- USING CMake version: 3.6.2
-- System: Linux
-- USING GCC_VERSION = '7.3.1 20180303 (Red Hat 7.3.1-5)'
-- Using gcc version 4 or later. Adding -frounding-math
== Generate version files (DONE) ==

-- Build type: Release
-- USING CXXFLAGS = ' -O3  -ftemplate-backtrace-limit=0 -std=c++14'
-- USING EXEFLAGS = '-pthread '
== Detect external libraries ==
== Detect external libraries (DONE) ==

== Generating build files ==
== Generating build files (DONE) ==

CMake Error at Installation/demo/CMakeLists.txt:1 (cmake_minimum_required):
  CMake 3.12...3.20 or higher is required.  You are running version 3.6.2

-- Configuring incomplete, errors occurred!
See also "/build/CMakeFiles/CMakeOutput.log".

Source Code

Environment

Operating system (Windows/Mac/Linux, 32/64 bits): Manjaro x86_64 running Docker
Compiler: Docker Bundle CGAL 3D demo error
Release or debug mode: release
Specific flags used (if any): Bundle CGAL 3D demo error
CGAL version: 5.4
Boost version: Docker Bundle CGAL 3D demo error
Other libraries versions if used (Eigen, TBB, etc.): docker Bundle CGAL 3D demo error

sloriot commented 2 years ago

Here is the relevant part of the log:

CMake Error at Installation/demo/CMakeLists.txt:1 (cmake_minimum_required):
  CMake 3.12...3.20 or higher is required.  You are running version 3.6.2

You need to use a more recent version of cmake.

kikislater commented 2 years ago

Please reopen, it's cmake inside your docker image, not my distribution ...

sloriot commented 2 years ago

What do you mean by "your docker image"? Our test images are here: https://github.com/CGAL/cgal-testsuite-dockerfiles

lrineau commented 2 years ago

@sloriot @kikislater is talking about the container image from https://github.com/CGAL/bundle-CGAL-3D-demo.

kikislater commented 2 years ago

It builds fine with old version CGAL-5.1-Ic-152 tried :

docker run --rm -t -i -v $PWD/build:/build:Z -v $PWD/results:/results:Z -v $PWD/scripts:/scripts:ro -v $PWD/dist:/dist:Z -v /home/sylvain/build/CGAL-5.1-Ic-152/:/cgal:ro docker.io/cgal/bundle-3d-demo  'bash -x /scripts/build.sh -j6 && bash -x /scripts/deploy.sh'

But not with recent cgal release due to out of date package in docker image available in docker hub

janetournois commented 1 year ago

@lrineau @SaillantNicolas is this fixed in latest versions of the docker images?

lrineau commented 1 year ago

Actually, the latest version of the Docker image dates from 2020. And, as it was not tested, it has rotted, as any piece of code that is not tested.

We should:

update the image so that is can create a correct pre-compiled Linux version of CGAL Lab,
and then add it to our CI process, so that we are sure it will stay up-to-date.

CGAL / cgal