Triangulation_3: Memory leak in T_3 parallel (TBB)

[lrineau]

On https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.5.2-I-132/Triangulation_3/TestReport_lrineau_Fedora-Release.gz, asan complains about memory leaks for test_delaunay_3 and test_regular_3.

Originally posted by @MaelRL in https://github.com/CGAL/cgal/issues/7115#issuecomment-1368871335

[lrineau]

Update of that issue. It is still present in recent internal releases. The last one has the issue: https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.5.3-I-147/Triangulation_3/TestReport_lrineau_Fedora-Release.gz

However, as for master, the last occurrence was in CGAL-5.6-I-14, dated end of June 2022. That is also the last release of CGAL where CGAL_LINKED_WITH_TBB is used. That is a bug: TBB should be used.

[lrineau]

I can confirm all my findings:

• in master, since the merge of #6646, find_package(TBB) is disabled with CMAKE_DISABLE_FIND_PACKAGE_TBB if CGAL_USE_ASAN is true: https://github.com/CGAL/cgal/blob/c36d6df775f930880eae243385f33380d3ccc479/Installation/cmake/modules/CGAL_SetupCGALDependencies.cmake#L116-L120 that means that in our testsuite, TBB is no longer tested with ASAN, on purpose.
• when the combination of ASAN+TBB is tested (master before CGAL-5.6-I-14, or previous release branches), then TBB-2020 triggers memory leaks, and oneAPI-TBB-2021 does not.

So, that means that I could close this issue, because it is in TBB. Another good action would be to install oneAPI-TBB on Fedora-Release, and reactivate ASAN+TBB for that test platform.

@afabri Advice?

[afabri]

Advice on what? I guess we should use ASAN only for a TBB without memory leak as we want to focus on those in CGAL itself.