CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.87k stars 1.38k forks source link

Isotropic meshing: missing requirements #806

Closed sloriot closed 8 years ago

sloriot commented 8 years ago

The doc does not mention that the halfedge_descriptor must be a model of Hashable.

cc @janetournois

sloriot commented 8 years ago

Actually face_descriptor must also be a model of Hashable

afabri commented 8 years ago

I would suggest that this becomes part of the Descriptor concept.

sloriot commented 8 years ago

For now I only encountered the need for one function in PMP (not in Euler, not in Helpers).

afabri commented 8 years ago

You will encounter it whenever we have a hash map as an implementation detail.

Note also that we do not say in Descriptor that it must be LessThanComparable

afabri commented 8 years ago

On the practical side, do we check that the OpenMesh descriptors are hashable??