CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.68k stars 1.35k forks source link

Rename Polyhedron demo to CGAL Lab everywhere #8149

Closed lrineau closed 2 months ago

lrineau commented 2 months ago

Summary of Changes

Followup to #8099. Finish to rename occurrences of the name "polyhedron demo" to "CGAL Lab".

Release Management

sloriot commented 2 months ago

CGAL 6.0-Ic-225 package doc overview page has been updated correctly and cgalab.zip has been correctly generated. Maybe someone on windows should try to run it and report that the demo could be run? Check https://www.cgal.org/demo/6.0/cgallab.zip

janetournois commented 2 months ago

I'm doing it

janetournois commented 2 months ago

The demo started correctly, and all the plugins found could be loaded (they are all green in "preferences") However, the executable is still called Polyhedron_3.exe and the title bar of the window still is "CGAL Polyhedron demo"

afabri commented 2 months ago

And I guess that about.html has to be changed as well.

sloriot commented 2 months ago

The demo started correctly, and all the plugins found could be loaded (they are all green in "preferences") However, the executable is still called Polyhedron_3.exe and the title bar of the window still is "CGAL Polyhedron demo"

So it means it is still the old demo. We have to wait a master testsuite I guess

sloriot commented 2 months ago

image

afabri commented 2 months ago

We might change 2009 to 2024 in the about.

janetournois commented 2 months ago

With the downloaded version image

sloriot commented 2 months ago

Actually the one that should be tested is here: https://cgal.geometryfactory.com/~cgaltest/incoming/demos-CGAL-6.0-Ic-225_Christo-test190420240100-MSVC-2022-Community-Release-cmake.tar.gz

janetournois commented 2 months ago

This one is fine :-) One last comment about the name cgallab.exe : can we capitalize CGAL to make it easier to find and more friendly looking?

lrineau commented 2 months ago

This one is fine :-) One last comment about the name cgallab.exe : can we capitalize CGAL to make it easier to find and more friendly looking?

About a year ago, at the developers meeting N-1, we voted that:

Application title name:

     CGAL Lab

Executable name (Unix/Windows):

     cgallab
     cgallab.exe

You say you want cgal uppercase. Which one do you prefer?

  1. CGALlab.exe,
  2. CGALLab.exe, or
  3. CGAL Lab.exe?
janetournois commented 2 months ago

I would vote for CGALlab.exe :-)

sloriot commented 2 months ago

Successfully tested in CGAL-6.0-Ic-228

lrineau commented 2 months ago

@CGAL/developers Note that now the "polyhedron demo" is now named "CGAL Lab" (short name and executable name CGALlab). Its source code was moved in the Lab/demo/Lab/ directory.