PMP::isotropic_remeshing() - add NP `allow move functor`

CGAL / cgal

The public CGAL repository, see the README below

https://github.com/CGAL/cgal#readme

Other

4.68k stars 1.35k forks source link

PMP::isotropic_remeshing() - add NP `allow move functor` #8150

Closed janetournois closed 1 month ago

janetournois commented 2 months ago

Summary of Changes

The function tangential_relaxation() has a named parameter called allow_move_functor that enables the user to prevent and cancel some vertex moves.

With this PR, it is now possible to use the same parameter for the relaxation steps of CGAL::Polygon_mesh_processing::isotropic_remeshing()

Release Management

Affected package(s): PMP
Issue(s) solved (if any): partially solves issue #8134
Link to compiled documentation (obligatory for small feature) wrong link name to be changed
License and copyright ownership: unchanged

janetournois commented 2 months ago

To solve #8134, we can think of a smart functor that would prevent self-intersections from being introduced by the relaxation step

sloriot commented 2 months ago

Successfully tested in CGAL-6.0-Ic-235

lrineau commented 1 month ago

To solve #8134, we can think of a smart functor that would prevent self-intersections from being introduced by the relaxation step

Should we close the issue #8134, how that this PR is merged, or leave it open? Because it seems the actual solution to #8134 is

this PR #8150,
plus something else (see the quote above).

janetournois commented 1 month ago

I will post a possible functor in the issue soon! Thanks for assigning it to me