search

CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.68k stars 1.35k forks source link

Making the Spherical Guassian-map polyhedron a proper model of FaceGraph #8153

Closed efifogel closed 1 month ago

efifogel commented 2 months ago

Summary of Changes

The old code does not compile. While the interface is not published, people may still search and find this piece of code, so better have it right.

Release Management

sloriot commented 2 months ago

@efifogel does it make sense to have a test compiling it, just to make sure it is not broken at some point?

efifogel commented 2 months ago

Sure, I'll add one.

//) o /__ // (__ ( ( ( (/ (/-(-'(/ /

On Mon, 22 Apr 2024 at 09:41, Sebastien Loriot @.***> wrote:

@efifogel https://github.com/efifogel does it make sense to have a test compiling it, just to make sure it is not broken at some point?

— Reply to this email directly, view it on GitHub https://github.com/CGAL/cgal/pull/8153#issuecomment-2068603026, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBNOHFDOJSPWMZYLAZLQDY6SWJTAVCNFSM6AAAAABGQSOSP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGYYDGMBSGY . You are receiving this because you were mentioned.Message ID: @.***>

efifogel commented 2 months ago

ok, did that (added some code to test that it compiles). PS, in the near future I plan to submit a new feature (or at least a small feature) that publishes this code (Gaussian map, a.k.a. normal diagram, of a convex polyhedron).

//) o /__ // (__ ( ( ( (/ (/-(-'(/ /

On Mon, 22 Apr 2024 at 10:41, Efi Fogel @.***> wrote:

Sure, I'll add one.

//) o /__ // (__ ( ( ( (/ (/-(-'(/ /

On Mon, 22 Apr 2024 at 09:41, Sebastien Loriot @.***> wrote:

@efifogel https://github.com/efifogel does it make sense to have a test compiling it, just to make sure it is not broken at some point?

— Reply to this email directly, view it on GitHub https://github.com/CGAL/cgal/pull/8153#issuecomment-2068603026, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBNOHFDOJSPWMZYLAZLQDY6SWJTAVCNFSM6AAAAABGQSOSP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGYYDGMBSGY . You are receiving this because you were mentioned.Message ID: @.***>

sloriot commented 2 months ago

Successfully tested in CGAL-6.0-Ic-235