IO: Fix `OutputIteratorValueType` being ignored

CGAL / cgal

The public CGAL repository, see the README below

https://github.com/CGAL/cgal#readme

Other

4.89k stars 1.38k forks source link

IO: Fix `OutputIteratorValueType` being ignored #8155

Closed nh2 closed 5 months ago

nh2 commented 5 months ago

The template typename OutputIteratorValueType was unused.

This made specifying it (as suggested by the docs) ineffective, and forbade to use PLY functions e.g. with boost::function_output_iterator, or any other output iterator whose value_type is void.

Release Management

Affected package(s): Point_set_processing_3
License and copyright ownership: no change

afabri commented 5 months ago

It would be good to add Stream_support/test/Stream_support/issue8155.cpp which shows before/after. @soesau can you please do that.

sloriot commented 5 months ago

Successfully tested in CGAL-6.0-Ic-228

lrineau commented 5 months ago

It would be good to add Stream_support/test/Stream_support/issue8155.cpp which shows before/after. @soesau can you please do that.

@soesau There is still that TODO.

lrineau commented 5 months ago

It would be good to add Stream_support/test/Stream_support/issue8155.cpp which shows before/after. @soesau can you please do that.

@soesau There is still that TODO.

I have created #8163 to track that TODO. I will merge this PR now.

lrineau commented 5 months ago

Now merged. Thanks @nh2 for your contribution.

nh2 commented 5 months ago

Thanks for the quick fix!