search

CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.89k stars 1.38k forks source link

Rename parameters #8178

Closed sloriot closed 4 months ago

sloriot commented 5 months ago

Fixes #8176

albert-github commented 5 months ago

Wouldn't it be more consistent to replace all NamedParametersOut... by NPOut... in this package? Analogous for NamedParametersIn... rename to NPIn... and NamedParameters... to NP....

lrineau commented 5 months ago

/build:fix-v1

github-actions[bot] commented 5 months ago

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8178/fix/Manual/index.html

lrineau commented 5 months ago

That is better. Now it fits just in the width of my screen: https://cgal.github.io/8178/fix/Polygon_mesh_processing/group__PMP__corefinement__grp.html#gae3553532387bd3ecfbcb72f4f092c7bc

sloriot commented 5 months ago

Wouldn't it be more consistent to replace all NamedParametersOut... by NPOut... in this package? Analogous for NamedParametersIn... rename to NPIn... and NamedParameters... to NP....

I don't have a strong opinion. I'll have to go through the logs of the review to check if that was a request from the reviewers.

afabri commented 5 months ago

It should also be changed for the input parameters.

sloriot commented 4 months ago

Successfully tested in CGAL-6.0-Ic-237