CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.67k stars 1.35k forks source link

Document issue about generalized map's insert 2-cell in 3-cell #8195

Closed eiiijiiiy closed 1 month ago

eiiijiiiy commented 1 month ago

The example of inserting a 2-cell in a 3 cell given in the user manual of Package Generalized Maps lists the inserted 2-cell as std::vector{dh1, ..., dh8}, as shown in the figure below. However, if I understand it correctly, the implementation of is_insertable_cell_2_in_cell_3 and the other example of gm operations indicate it should be std::vector{dh1, dh3, dh5, dh7} instead of the full loop from dh1 to dh8. The latter actually fails the assertion of is_insertable_cell_2_in_cell_3.

image
gdamiand commented 1 month ago

Thanks for the issue: this is indeed a bug in the doc. Fixed in #8199.

lrineau commented 1 month ago

@eiiijiiiy Thanks. That is now merged and fixed in CGAL master branch. PR https://github.com/CGAL/cgal/pull/8199

eiiijiiiy commented 1 month ago

thanks all!!