Closed eiiijiiiy closed 1 month ago
The example of inserting a 2-cell in a 3 cell given in the user manual of Package Generalized Maps lists the inserted 2-cell as std::vector{dh1, ..., dh8}, as shown in the figure below. However, if I understand it correctly, the implementation of is_insertable_cell_2_in_cell_3 and the other example of gm operations indicate it should be std::vector{dh1, dh3, dh5, dh7} instead of the full loop from dh1 to dh8. The latter actually fails the assertion of is_insertable_cell_2_in_cell_3.
std::vector{dh1, ..., dh8}
is_insertable_cell_2_in_cell_3
std::vector{dh1, dh3, dh5, dh7}
dh1
dh8
Thanks for the issue: this is indeed a bug in the doc. Fixed in #8199.
@eiiijiiiy Thanks. That is now merged and fixed in CGAL master branch. PR https://github.com/CGAL/cgal/pull/8199
master
thanks all!!
The example of inserting a 2-cell in a 3 cell given in the user manual of Package Generalized Maps lists the inserted 2-cell as
std::vector{dh1, ..., dh8}
, as shown in the figure below. However, if I understand it correctly, the implementation ofis_insertable_cell_2_in_cell_3
and the other example of gm operations indicate it should bestd::vector{dh1, dh3, dh5, dh7}
instead of the full loop fromdh1
todh8
. The latter actually fails the assertion ofis_insertable_cell_2_in_cell_3
.