CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.67k stars 1.35k forks source link

PMP isotropic_remeshing - add example using `allow_move_functor` #8210

Open janetournois opened 1 month ago

janetournois commented 1 month ago

Summary of Changes

add an example using named parameter introduced in PR #8150

Release Management

lrineau commented 1 month ago

Nice feature. Note https://github.com/CGAL/cgal/pull/8150#discussion_r1605006265, that could be fixed in this PR.

lrineau commented 1 month ago

By the way, it seems the API introduced in #8150 would also allow to use a lambda expression, as argument to allow_move_functor, right?

Would not it be a better example, with a lambda? I am actually note sure... For some readers, lambda functions are kind of magic, whereas they just regular functor classes, defined with a special syntax. I am not completely sure what is the best way to recommend or teach, as an example.

janetournois commented 1 month ago

Nice feature. Note #8150 (comment), that could be fixed in this PR.

done

janetournois commented 1 month ago

My choice would be to write as-readable-as-possible examples, as long as it does not impact performance

lrineau commented 1 month ago

Jane, this PR was submitted as a draft. You have removed the TODO label. Is it still a draft?

sloriot commented 1 week ago

PMP test failings in CGAL-6.0-Ic-276