CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.89k stars 1.38k forks source link

Dependencies file with tag files and the resulting doxygen "dxy" file #8211

Closed albert-github closed 3 months ago

albert-github commented 4 months ago

With the fix b9ee8c6 a fix (by @sloriot) was made to fix the issue:

error: Tag file '.../doc_tags/Lab.tag' does not exist or is not a file. Skipping it...

when building the documentation of the (not really supported) Three package. The fix as is is correct and worked for a clean build, but when using an existing build it didn't work as the Three.dxy configuration file was not rebuild and a remake of the cmake files was not triggered. The change was made in the file Three/doc/Tree/dependencies and this is not listed as a dependency to regenerate the Three.dxy

In an email discussion it was pointed out by @lrineau that:

The answer is probably https://cmake.org/cmake/help/latest/prop_dir/CMAKE_CONFIGURE_DEPENDS.html

The solution lies probably in Documentation/doc/CMakeLists.txt where a configuration dependency between: ${depend}/doc/${depend}/dependencies and ${CGAL_DOC_DXY_DIR}/${depend}.dxy has to be created, where depend is a package name).

lrineau commented 3 months ago

I was bitten by that bug, and it made me loss minutes of work. So I fixed it in the unrelated PR #8248 (commit 50d7abaec581981930f8093a8f0668a83e6406c8).

lrineau commented 3 months ago

I was bitten by that bug, and it made me loss minutes of work. So I fixed it in the unrelated PR #8248 (commit 50d7aba).

Should be fixed in CGAL master, now. @albert-github, do you confirm the bug is fixed?

albert-github commented 3 months ago

I did a quick test.

This confirms to me that this problem is fixed.