Surface_mesh: Add exact_num_faces(const SM&)

CGAL / cgal

The public CGAL repository, see the README below

https://github.com/CGAL/cgal#readme

Other

4.67k stars 1.35k forks source link

Surface_mesh: Add exact_num_faces(const SM&) #8215

Closed afabri closed 1 month ago

afabri commented 1 month ago

Summary of Changes

Add a partial specialization for CGAL::internal::exact_num_faces(const Surface_mesh&) to have an O(1) time. This was pointed out as important for the Face_count_stop_predicate in Issue #8158

Release Management

Affected package(s): Surface_mesh
Issue(s) solved (if any): fix #5720
License and copyright ownership: unchanged

sloriot commented 1 month ago

why only one and not the four?

lrineau commented 1 month ago

TODO: that new function overload needs a test.

It is used in Surface_mesh_simplification. How do you want me to check that the specialization is taken? Add an #ifdef CGAL_TESTSUITE with a std::cout ?

sloriot commented 1 month ago

Successfully tested in 6.0-Ic-251