search

CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
5k stars 1.39k forks source link

rename `time_stamp` to `timestamp` #8218

Open lrineau opened 5 months ago

lrineau commented 5 months ago

Issue

In CGAL, since version 4.5 (around May 2014), there is something called time_stamper, that I introduced to achieve efficient determinism of Mesh_3 (see the small feature page, only for CGAL developers), and see the commit 156a4b3f9b7df37e29cb7c8248d00ddae7f8d7d4 that adds this feature.

It is not documented, and it has probably never been properly reviewed.

Much later, I learned that in English it is not spelled "time stamp", but only "timestamp". https://en.wiktionary.org/wiki/timestamp Since then, every time I search for this file in CGAL, I remember this mistake.

In addition, it is not even consistent, because sometimes in more recent additions to CGAL, the spelling has been corrected, for example <CGAL/Has_timestamp.h>.

It should be renamed, all over CGAL.

Proposed changes

thepiyush-303 commented 4 months ago

Hello @lrineau , I can fix this issue, Do you want this change in entire codebase?

lrineau commented 4 months ago

Hello @lrineau , I can fix this issue, Do you want this change in entire codebase?

Thanks. Actually, yes. But it should be quite limited to a few files... 43 files as far as I can see.

afabri commented 3 months ago

I thought it was "42". grep shows much more occurences, so we need some clarification on the scope.