SMS: Make Lindstrom Turk placement more robust

CGAL / cgal

The public CGAL repository, see the README below

https://github.com/CGAL/cgal#readme

Other

4.67k stars 1.35k forks source link

SMS: Make Lindstrom Turk placement more robust #8237

Open afabri opened 1 month ago

afabri commented 1 month ago

Summary of Changes

Reduced data set to illustrate Issue #8213. The collapse of edge v1-v2 results in a completely wrong placement of the vertex.

The next step is to make the placement robust.

Release Management

Affected package(s): Surface_mesh_simplification.
Issue(s) solved (if any): fix #8213
License and copyright ownership: unchanged

lrineau commented 1 month ago

For the moment this PR adds only a test. You probably forgot to commit/push the actual fix.

lrineau commented 1 month ago

The next step is to make the placement robust.

I missed that part. I have turned this into a draft PR, and added a https://github.com/CGAL/cgal/labels/TODO label, to avoid this bug-fix PR be merged by accident.

afabri commented 1 month ago

We could even add it to the testsuite so that the error shows up.