CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.88k stars 1.38k forks source link

cmake_minimum_required(VERSION 3.12...3.29) #8263

Closed lrineau closed 3 months ago

lrineau commented 3 months ago

Summary of Changes

Change all cmake_minimum_required to

cmake_minimum_required(VERSION 3.12...3.29)

Release Management

lrineau commented 3 months ago

This PR is a blocker for CGAL-6.0-beta1, because it impacts downstream packages.

lrineau commented 3 months ago

I have checked with cmake versions 3.12, 3.18, 3.19, and 3.29 (thanks to Fedora toolbox and a setup script).

lrineau commented 3 months ago

That does not work with cmake-3.11, and I do not really understand why.

With cmake -DWITH_tests=ON, the error is:

-- Configuring test in test/Installation
CMake Warning (dev) at Installation/cmake/modules/CGAL_add_test.cmake:176 (if):
  Policy CMP0064 is not set: Support new TEST if() operator.  Run "cmake
  --help-policy CMP0064" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  TEST will be interpreted as an operator when the policy is set to NEW.
  Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
  Installation/cmake/modules/CGAL_add_test.cmake:357 (cgal_setup_test_properties)
  Installation/test/Installation/CMakeLists.txt:13 (CGAL_add_test)
  Installation/test/Installation/CMakeLists.txt:39 (create_link_to_program)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Error at Installation/cmake/modules/CGAL_add_test.cmake:176 (if):
  if given arguments:

    "NOT" "TEST" "copy source_dir of Installation_Tests"

  Unknown arguments specified
Call Stack (most recent call first):
  Installation/cmake/modules/CGAL_add_test.cmake:357 (cgal_setup_test_properties)
  Installation/test/Installation/CMakeLists.txt:13 (CGAL_add_test)
  Installation/test/Installation/CMakeLists.txt:39 (create_link_to_program)

-- Configuring incomplete, errors occurred!
sloriot commented 3 months ago

Successfully tested in CGAL-6.0-Ic-264