search

CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
4.89k stars 1.38k forks source link

Installation - update `FindOpenMesh.cmake` #8332

Closed janetournois closed 3 weeks ago

janetournois commented 3 months ago

Summary of Changes

This PR updates CGAL's FindOpenMesh.cmake, accordingly with the one provided by OpenMesh 11.0, and introducing the target OpenMesh::OpenMesh

Release Management

sloriot commented 3 months ago

Since the target is from CGAL, shouldn't be prefixed with CGAL? Or even CGAL_OpenMesh_support to be consistent?

sloriot commented 2 months ago

Successfully tested in CGAL-6.0-Ic-300

janetournois commented 2 months ago

I have unpushed temporary code to add the CGAL prefix as you suggested @sloriot Do not merge this PR yet

github-actions[bot] commented 1 month ago

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

janetournois commented 1 month ago

Christo is up-to-date to test CGAL examples with OpenMesh-11.0

sloriot commented 3 weeks ago

Successfully tested in CGAL-6.0-Ic-321