search

CGAL / cgal

The public CGAL repository, see the README below
https://github.com/CGAL/cgal#readme
Other
5.02k stars 1.39k forks source link

Deprecated Qt function #8589

Open afabri opened 2 weeks ago

afabri commented 2 weeks ago

We have a warning in this testsuite.

Lab_Demo/Plugins/PCA/Basic_generator_plugin.cpp:145:53: warning: ‘void QCheckBox::stateChanged(int)’ is deprecated: Use checkStateChanged() instead [-Wdeprecated-declarations]

But according to the Qt documentation we can replace only if we go for Qt 6.7 as minimal version, while we require only 6.4 here

afabri commented 2 weeks ago

@sloriot @lrineau do you have suggestions when is a good time to raise the minimal version?

sloriot commented 2 weeks ago

6.7 was released in april 2024. It will take some time before it will be in stable debian/ubuntu repos.

afabri commented 2 weeks ago

So we might reconsider this in May 2025.

lrineau commented 1 week ago

We could add the definition QT_WARN_DEPRECATED_UP_TO=0x60700 to the basic_generator_plugin target:

target_compile_definitions(basic_generator_plugin PRIVATE QT_WARN_DEPRECATED_UP_TO=0x60700)

That will disable the warning.