efifogel
commented
2 weeks ago Thanks; fixed all.
//) o /__ // (__ ( ( ( (/ (/-(-'(/ /
On Wed, 6 Nov 2024 at 19:09, albert-github @.***> wrote:
@.**** commented on this pull request.
I just read quickly through the file, same problems might exist in other files.
In Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Arr_counting_traits_2.h https://github.com/CGAL/cgal/pull/8592#discussion_r1831415720:
+// All rights reserved. +// +// This file is part of CGAL (www.cgal.org). +// +// $URL$ +// $Id$ +// SPDX-License-Identifier: GPL-3.0-or-later OR LicenseRef-Commercial +// +// Author(s): Efi Fogel @.> +// Eric Berberich @.> + +namespace CGAL { + +/*! \ingroup PkgArrangementOnSurface2TraitsClasses
- *
- A meradata traits-class decorator for the arrangement package. It counts the
meradata -> metadata ?
In Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Arr_counting_traits_2.h https://github.com/CGAL/cgal/pull/8592#discussion_r1831417392:
+// $Id$ +// SPDX-License-Identifier: GPL-3.0-or-later OR LicenseRef-Commercial +// +// Author(s): Efi Fogel @.> +// Eric Berberich @.> + +namespace CGAL { + +/*! \ingroup PkgArrangementOnSurface2TraitsClasses
- *
- A meradata traits-class decorator for the arrangement package. It counts the
- number of invocations of traits-class functors. It is parameterized with
- another traits class and inherits from it. For each traits method it
- maintains a counter that counts the number of invocations into the method.
- *
- It models all the concept that the original trais models.
trais -> traits? concept -> concepts?
In Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Arr_counting_traits_2.h https://github.com/CGAL/cgal/pull/8592#discussion_r1831418107:
- /*! Disable copy constructor.
- */
one line?
In Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Arr_counting_traits_2.h https://github.com/CGAL/cgal/pull/8592#discussion_r1831418948:
- /// @{
- /! Construct default /
- template <typename ... Args>
- Arr_counting_traits_2(Args ... args) : Base(std::forward
(args)...) {} - /*! Disable copy constructor.
- */
- Arr_counting_traits_2(const Arr_counting_traits_2&) = delete;
- /// @}
- /! Obtain the counter of the given operation /
- std::size_t count(Operation_id id) const;
- /! Print the compare_x counter /
compare_x ?
— Reply to this email directly, view it on GitHub https://github.com/CGAL/cgal/pull/8592#pullrequestreview-2418942632, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBNOHHEMIZLPUGODX2Z23Z7JELNAVCNFSM6AAAAABRJEXJ7OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJYHE2DENRTGI . You are receiving this because you authored the thread.Message ID: @.***>
afabri
sloriot
Summary of Changes
Introduces two traits decorators, namely
Arr_tracing_traits_2andArr_counting_traits_2, which can be used to extract debugging and informative metadata about the traits in use while the program is being executed. They have been part of the CGAL distribution for several years now . (Probably more than a decade.) I gave it a face lift, wrote the necessary documentation, and added a small example program called count_and_trace.cpp.Release Management