fix read1 error in writing filtered result

CGATOxford / UMI-tools

Tools for handling Unique Molecular Identifiers in NGS data sets

MIT License

491 stars 190 forks source link

fix read1 error in writing filtered result #452

Closed y9c closed 3 years ago

IanSudbery commented 3 years ago

Is it possible to link this to an issue describing the problem you are trying to fix?

As far as I can tell, your change at line 446 looks reasonable, but the change at 427 looks like it means that no read1 will ever be output unless output of filtered reads is set to true. I assume this is why the PR test is failing.

y9c commented 3 years ago

clsoe #453

IanSudbery commented 3 years ago

Thanks for contributing, we appreciate it.