search

CGATOxford / UMI-tools

Tools for handling Unique Molecular Identifiers in NGS data sets
MIT License
491 stars 190 forks source link

Update Python versions for tests #658

Closed sebastian-luna-valero closed 1 month ago

sebastian-luna-valero commented 3 months ago

See: https://devguide.python.org/versions/

xrefs:

Once these tests work, we could re-enable python 3.12 in the bioconda recipe.

sebastian-luna-valero commented 3 months ago

ok, so I am in a rush and don't have time to fix these errors.

we should replace nose with nose2 or pytest. However, that means refactoring tests/test_umi_tools.py.

could you please help here?

IanSudbery commented 3 months ago

Hi @sebastian-luna-valero. There is already work on this at #655. Different python versions result in different results from the tests, so we are waiting on #550 which should make the results more deterministic as long as a random seed is provided.

TomSmithCGAT commented 1 month ago

Now resolved by #655. Thanks @sebastian-luna-valero