CGATOxford / UMI-tools

Tools for handling Unique Molecular Identifiers in NGS data sets
MIT License
493 stars 190 forks source link

No v1.1.6 on conda, and only prebuilt for MacOS (no source) on pypi #663

Open eachanjohnson opened 1 month ago

eachanjohnson commented 1 month ago

Describe the bug I could not install the latest v1.1.6 release on Linux using either conda install umi_tools=1/1/6 or pip install umi_tools==1.1.6. Installing from GitHub works with pip install git+https://github.com/CGATOxford/UMI-tools@v1.1.6.

To Reproduce Try conda install umi_tools=1.1.6.

Expected behavior To be able to install the v1.1.6 release.

Environment

Additional context It looks like 1.1.6 isn't on the conda index at all, and only pre-built MacOS binaries and no source are available on pypi. Screenshot 2024-10-09 at 17 09 12 Screenshot 2024-10-09 at 17 09 36

Additional context: thanks so much for continuing to maintain this great suite of tools! 🙇

TomSmithCGAT commented 1 month ago

Thank you for catching this @eachanjohnson! That'll teach me for rushing through a random blog post to remind myself how to upload packages to pypi 🤦

As suggested in the blog, I ran python setup.py bdist_wheel, when I should of run python setup.py sdist, hence the lack of source code in the upload. That's been rectified now.

I did note previously that bioconda didn't immediately update umi_tools, but figured I was just being too impatient and forgot to check back. Previously, the bioconda bot picked it up fairly quickly (within a few hours if I remember right). I'll check again tomorrow whether uploading the source is sufficient to get the bot to pick it up. If not, I'll make a manual PR. I'll leave this open until bioconda has the latest version too.

eachanjohnson commented 1 month ago

I have a GitHub action for uploading to pypi when a release is made. I could make a PR perhaps tomorrow to include it if helpful.

TomSmithCGAT commented 1 month ago

That would be really useful, thank you 🙏

I looked into using a Github action for automating the uploading, but I can't remember where I got stuck. Don't see any reason why a generic action shouldn't work perfectly fine here.