search

CGCookie / blender-addon-updater

A module for enabling users to check for add-on updates and install new versions directly from Blender.
GNU General Public License v3.0
247 stars 42 forks source link

Failures to delete directories #67

Closed Dragorn421 closed 3 years ago

Dragorn421 commented 4 years ago

Context

Some users and myself have been having issues, all linked to filesystem operations, on Windows, with different Blender 2.7x/2.8x versions.

Relevant Addon using blender-addon-updater / Latest revision at time of writing

This isn't a permissions issue as the addon can create the *_updater folder

Issue 1

A user encountered this when trying to update

Click to expand ![error in ui](https://cdn.discordapp.com/attachments/631723103830933504/743962636017860608/Capture.PNG) ![delete folder errors in console](https://cdn.discordapp.com/attachments/631723103830933504/743963073358069861/Capture.PNG)

Deleting the folder manually allowed the updater to function properly then.

Issue 2

I also had weird issues originating from shutil (I don't have the logs anymore sorry) which may have been due to paths being too long

The real issue being that those paths became too long because the addon was backuping its backups, after failing to delete previous backups. shutil failed midway through traversing the directory tree.

Fix

?

I think it would be better to not catch-all and ignore exceptions like here, because it clearly prevents us here to actually understand what's going on.

TheDuckCow commented 4 years ago

Firstly, thank you sharing your steps, screenshots, and troubleshooting so far.

Regarding the fix, I think it's fair that we should at least print the raw, full traceback message to the console. I'd still like to pass forward the more user friend message, which is what the error handler there does. We could also capture the error in the message presented to the UI too, so anyone who screenshots it gets that.

As for the other points about recursive backups, that sounds plausible. Especially if there were prior errors. The updater should do a better job at skipping that backup/tmp folder when running a backup, regardless of the circumstances.

No immediate ETA, but this is what I would work on.

TheDuckCow commented 3 years ago

FYI that I created this commit which should largely address the original issue (so long as the issue has more to do with excessive long paths in the backup folder): https://github.com/CGCookie/blender-addon-updater/commit/44bc9439d422c2c03c3776d90ad45bae1903d379

Closing in the meantime, but if you do happen to try this and find issues, let me know.