search

CH-Earth / CWARHM

GNU General Public License v3.0
29 stars 35 forks source link

MizuRoute compile flags outdated #169

Open wknoben opened 6 months ago

wknoben commented 6 months ago

https://github.com/CH-Earth/CWARHM/blob/8540d65e99f9fde311900d4e23934f40b3ce8bd7/2_install/2b_compile_mizuroute.sh#L97

Flags here were hard-coded for traceability:

FLAGS="-O3 -ffree-line-length-none -fmax-errors=0 ${FLAGS_OMP}"

Expected inputs for mizuRoute have changed (version v1.2.3, branch description main-0-g0a62ee6, hash 0a62ee6185bdc9b99cd88ed5f15ea850602c43a2). Example ("fast" mode):

FLAGS = -O3 -fmax-errors=0 -ffree-line-length-none $(FLAGS_OMP) -cpp -DVERSION=\"$(VERSION)\" -DBRANCH=\"$(GITBRCH)\" -DHASH=\"$(GITHASH)\"

Adding the new part 

cpp -DVERSION=\"$(VERSION)\" -DBRANCH=\"$(GITBRCH)\" -DHASH=\"$(GITHASH)\"

to the script here might resolve this issue.

wknoben commented 6 months ago

Apparently this doesn't work as suggested. Simply removing the flag specification from 2a_compile_mizuroute.sh and relying on the logic inside mizuRoute's makefile to set the correct flags is probably better.