search

CH-Earth / CWARHM

GNU General Public License v3.0
29 stars 35 forks source link

Enhancements #52

Open DaveCasson opened 3 years ago

DaveCasson commented 3 years ago
    • The Jupyter Notebooks are all look for a kernel as follows: Could not find a kernel matching Python [conda env:geospatialTools_candexTest]. Setting the kernels to summa-venv (or summa-conda-env) would avoid this.

  2. Create small utility functions to hold commonly used commands such as: -read_from_control( file, setting ) -make_default_path(suffix): -Create a log file, suggest using logger package

  3. Use ipynbname to extract the name and path of Jupyter notebooks

wknoben commented 3 years ago

Thanks, I'll take these under consideration.

wknoben commented 3 years ago

Leaving this here for future reference (scripts only): https://gis.stackexchange.com/questions/177882/getting-script-file-name-as-object-in-python

wknoben commented 3 years ago

Fixed the first one in #55.

guoqiang-tang commented 3 years ago

I agree with Dave as I also planned to suggest this. I think you can also create some common functions for shell scripts and import them when you need to use them. For example, many files have a recent commit of "Updated bash scripts to ignore lines starting with "#".". It is tiring to update files one by one and you may miss some scripts sometimes. Future adjustments are also possible.