search

CH-Earth / pyviscous

PyVISCOUS: Open-Source VISCOUS Code in Python
Other
5 stars 5 forks source link

`matplotlib` is not a requirement for running pyVISCOUS, only for running the examples #3

Closed wknoben closed 1 year ago

wknoben commented 2 years ago

https://github.com/h294liu/pyviscous/blob/cb5aeef7c288ac1383dc4f06678b2b06e7bea5d4/setup.py#L12

Unsure what best practice is to deal with this case. Consider removing matplotlib from setup.py.

h294liu commented 2 years ago

This is right, both jupyter and matplotlib are not needed in pyviscous run. Let me think about it. I probably need to discuss with Chris how to better separate pyvicous functions from example functions. Will keep you posted.