CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:
http://www.ral.ucar.edu/projects/summa
GNU General Public License v3.0
80 stars 105 forks source link

Incorrect specification for output statistics in documentation #336

Closed arbennett closed 5 years ago

arbennett commented 5 years ago

It appears that the sum and instantaneous output statistics are swapped in the docs. The documentation says the output control file is arranged as:

! varName          | outFreq | inst | sum | mean | var | min | max | mode
scalarSenHeatTotal | 24      | 0    | 1   | 1    | 0   | 1   | 1   | 0

But in the code it is:

type, public :: iLook_stat                                                                                                                                                                
  integer(i4b)    :: totl = integerMissing ! summation                                                                                                                                                                                                       
  integer(i4b)    :: inst = integerMissing ! instantaneous                                                                                                                                                                                                                                            
  integer(i4b)    :: mean = integerMissing ! mean over period                                                                                                                                                                                                                                  
  integer(i4b)    :: vari = integerMissing ! variance over period                                                                                                                                                                                                                                     
  integer(i4b)    :: mini = integerMissing ! minimum over period                                                                                                                                                                                                                                   
  integer(i4b)    :: maxi = integerMissing ! maximum over period                                                                                                                                                                    
  integer(i4b)    :: mode = integerMissing ! mode over period                                                                                                                                                                                                                                
endtype iLook_stat
bartnijssen commented 5 years ago

@arbennett : Can this be closed?

arbennett commented 5 years ago

Yes.