search

CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:
http://www.ral.ucar.edu/projects/summa
GNU General Public License v3.0
80 stars 105 forks source link

Crash when trying to divide snow layers above maxSnowLayers if using jrdn1991 layering #338

Closed arbennett closed 5 years ago

arbennett commented 5 years ago

SUMMA will segfault due to trying to access out of bounds memory if the number of snow layers tries to go above maxSnowLayers. This only occurs while using the jrdn1991 layering scheme. The main issue is that there aren't adequate checks if the maximum number of snow layers has been reached.

arbennett commented 5 years ago

Solved via #345