CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:
http://www.ral.ucar.edu/projects/summa
GNU General Public License v3.0
80 stars 105 forks source link

Simplified makefile #350

Closed bartnijssen closed 5 years ago

bartnijssen commented 5 years ago

Merge after PR #347

I propose that we simplify Part 0 of the makefile in the following way:

Tested with build settings on OS X.

arbennett commented 5 years ago

In the old makefile the variables were all commented out by default, which allowed you to have them set directly in your environment. Like this:

$ export FC=gfortran
$ export F_MASTER=..
$ export FC_EXE=gfortran
$ make

I kind of like that this is possible, but don't use it myself. I think it would be nice to either make this possible, or make it easy to comment out all of the required lines easily.

bartnijssen commented 5 years ago

Note that sample configurations can be documented on the SUMMA wiki: https://github.com/NCAR/summa/wiki/SUMMA-Makefile-Part-0-configuration

bartnijssen commented 5 years ago

@arbennett : Changes made - it now passes the CI build. I also updated the Dockerfile and added some configurations that I have been using in: https://github.com/NCAR/summa/wiki/SUMMA-Makefile-Part-0-configuration

bartnijssen commented 5 years ago

Close issue #342 when merged