search

CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:
http://www.ral.ucar.edu/projects/summa
GNU General Public License v3.0
80 stars 105 forks source link

check canopyTemp and canopyIce in restart file #362

Closed nmizukami closed 2 years ago

nmizukami commented 4 years ago

When using saved restart file to start the simulation, read_icond.f90 https://github.com/NCAR/summa/blob/825893588185f064ad07b9b51241ddb8b24669f6/build/source/engine/check_icond.f90#L152 checks if canopy Ice cannot exist when canopy temperature is above freezing. The model is terminated if this situation happens in the restart file. However, this situation can happen at any time steps during the simulations (Also, the model does not seem to check this situation happen each time step). see the canopyTemp_vs_canopyICE.txt

I am wondering if this check can be removed safely.

wknoben commented 2 years ago

Addressed in #481 by adding a threshold to the check that happens for restart files, so closing this for now.