Closed arbennett closed 4 years ago
@arbennett : Further testing is needed before this should be formally reviewed
Do you mean that further testing is needed before code review or before this can be reviewed science-wise? Just want to make sure I understand whether you want me to do anything at this time.
@bartnijssen - Further testing is needed before review of the code. You don't have to do anything yet.
It appears this is okay to be reviewed now.
I have evaluated the algorithm and tested all new parameters at multiple sites. It appears to be working in all tests. An example at Niwot Ridge, CO below.
Another example, testing the minimum wind speed threshold in meters/sec.
I am also updating documentation describing this new decision.
Will be merged before SUMMA V3.0 after completing series of PRs related to changes to decision file, file manager, and some general cleanup
This work with @cassielumbrazo adds a new decision along with a new parameterization. The decision is
snowUnload
, which will have 2 options.meltDripUnload
was the previously default implementation. The new parameterization,windUnload
implements a snow unloading scheme described in A new snow cover fraction parametrization for the ECHAM4 GCM eq 13.Further testing is needed before this should be formally reviewed, but appears to be working as intended:
This feature adds 4 new parameters which need to be specified. They are, along with some default values from Roesch et al: