search

CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:
http://www.ral.ucar.edu/projects/summa
GNU General Public License v3.0
80 stars 105 forks source link

rootingDepth check #383

Open andywood opened 4 years ago

andywood commented 4 years ago

If rootingDepth is deeper than the soil layer depths, SUMMA can error out unintelligibly ... it would be useful to put a check for this condition in read-params...

martynpclark commented 4 years ago

Roots are allowed to be deeper than the soil depth. In this case there is ET from the aquifer. This is done in var_derive.f90

andywood commented 4 years ago

thanks, I'll check on it. I had runs quitting last fall when the root depths were deeper than the soil layers. But it's possible those runs had that thin aquifer (0.35m) setting and I didn't notice the roots were deeper than both of the combination. if a check on rootdepth v soil+aquifer depth is already implemented I'll delete the issue.

martynpclark commented 4 years ago

It could be that it is not checking in the right place. The logic in var_derive may need to be implemented later. My intent was to put whatever roots "fit" into the soil and have the rest in the aquifer. Note that this does not work if there is no aquifer (it should exit gracefully and tell you why)