Make hruId a required variable for `coldState.nc` and `trialParameter.nc` checks

CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:

http://www.ral.ucar.edu/projects/summa

GNU General Public License v3.0

80 stars 105 forks source link

Make hruId a required variable for `coldState.nc` and `trialParameter.nc` checks #401

Open wknoben opened 4 years ago

wknoben commented 4 years ago

Both files have an hru dimension but do not require an hruId variable to be specified. trialParameters.nc has an hruIndex variable but this might not be used (#237). Making hruId a required variable allows additional checking that initial states and parameter values are assigned to the correct HRU.

Possibly related to #253 #348

andywood commented 3 years ago

If this is an 'optional' variable rather than required, it would be backward compatible for users. if the Ids are not supplied the additional checking would not be done. Not saying this is what to do, but it's a consideration to keep in mind.