Closed martynpclark closed 1 year ago
Could we simply set the conductivity to zero in this case? And maybe issue a warning?
@arbennett : Which conductivity would be set to 0?
Wouldn't it be easier to set the k_macropore
to k_soil
if k_macropore < k_soil
and issue a warning, just to make sure that the model continues. If we can modify the message to indicate what a user can do to fix this that may be helpful as well.
if(k_macropore(iLayer-nSnow) < k_soil(iLayer-nSnow))then
k_macropore(iLayer-nSnow) = k_soil(iLayer-nSnow)
message=trim(message)//"hydraulic conductivity for macropores is less than the hydraulic conductivity for micropores"
err=20; return
endif
@bartnijssen yes, this is a good idea. A better solution. It means that the model does not stop.
Yeah, I agree, @bartnijssen that sounds like a good solution.
Yeah, that was my suggestion earlier too ...
On Thu, Dec 3, 2020 at 3:15 PM Andrew Bennett notifications@github.com wrote:
Yeah, I agree, @bartnijssen https://github.com/bartnijssen that sounds like a good solution.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NCAR/summa/pull/436#issuecomment-738359108, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIKARN2IIMFPMGURCXHLRTSTAEWZANCNFSM4SS3FGPA .
I would also expand the message, to "hydraulic conductivity for macropores (VALUE) is less than the hydraulic conductivity for micropores (VALUE): resetting macropore conductivity to equal micropore value" and even give the gru/hru id if that's handy in the routine.
On Fri, Dec 4, 2020 at 8:55 AM Andrew Wood andywood.home@gmail.com wrote:
Yeah, that was my suggestion earlier too ...
On Thu, Dec 3, 2020 at 3:15 PM Andrew Bennett notifications@github.com wrote:
Yeah, I agree, @bartnijssen https://github.com/bartnijssen that sounds like a good solution.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NCAR/summa/pull/436#issuecomment-738359108, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIKARN2IIMFPMGURCXHLRTSTAEWZANCNFSM4SS3FGPA .
Implemented changes in a separate PR
The code to compute hydraulic conductivity in macropores is
which means that the hydraulic conductivity for macropores will be negative if the conductivity for macropores is greater than for micropores.
The total hydraulic conductivity is
and the total conductivity can be negative if there is substantial ice impedance.
It is a good idea to require that the conductivity for macropores be greater than for micropores.