search

CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:
http://www.ral.ucar.edu/projects/summa
GNU General Public License v3.0
79 stars 103 forks source link

Addition of functionality for inputting aspect and non-zero slope/aspect effects on radiation, and also a BUG FIX: correcting averageRoutedRunoff in run_oneGRU.f90 and qTimeDelay.f90 #454

Closed andywood closed 3 years ago

andywood commented 3 years ago

Made all suggested changes

martynpclark commented 3 years ago

The code looks good. Before merging, can I ask what tests were completed?

andywood commented 3 years ago

apologies for not responding before - the main thing was to compare the new basin runoff variable to total runoff and see that they matched. I didn't assess other variables. The problem before was basin runoff being wrong by a factor of about 2, which was 'fixed'. I think better numerical tests could be applied here, though.

On Thu, Apr 8, 2021 at 4:45 PM Martyn Clark @.***> wrote:

The code looks good. Before merging, can I ask what tests were completed?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NCAR/summa/pull/454#issuecomment-816279504, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIKARLTDW6XCFEDK476UTTTHYWXNANCNFSM42LUSF3A .