CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:
http://www.ral.ucar.edu/projects/summa
GNU General Public License v3.0
79 stars 103 forks source link

Feature/update decisions #466

Closed martynpclark closed 2 years ago

martynpclark commented 3 years ago

Make sure all the relevant boxes are checked (and only check the box if you actually completed the step):

martynpclark commented 3 years ago

The model decisions for summa included an option for num_method which was never used. Many existing settings files have the option itertive which is the home-grown backward Euler solution over long time steps.

The code has changed to give num_method two options: bEuler (the traditional home-grown backward Euler solution over long time steps) and sundials (the sundials solver, which will be incorporated in the code base in the near future). We have retained the option itertive (set to bEuler) so that existing settings files will be valid.

arbennett commented 3 years ago

@martynpclark this looks good, but I have one request - could you add a quick entry to the docs/whats-new.md list under the header Develop from your previous PR?

martynpclark commented 2 years ago

No need to add whatsnew because just a placeholder for the sundials solver