DO NOT MERGE: The enthalpy form of the heat equation - Githubissues

CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:

http://www.ral.ucar.edu/projects/summa

GNU General Public License v3.0

80 stars 105 forks source link

DO NOT MERGE: The enthalpy form of the heat equation #469

Closed martynpclark closed 1 year ago

martynpclark commented 3 years ago

Make sure all the relevant boxes are checked (and only check the box if you actually completed the step):

[ ] closes #xxx (identify the issue associated with this PR)
[ ] tests passed
[ ] new tests added
[ ] science test figures
[ ] checked that the new code conforms to the SUMMA coding conventions
[ ] ReleaseNotes entry

martynpclark commented 3 years ago

The majority of this PR is to incorporate enthalpy as a diagnostic variable. It also implements the enthalpy form of the heat equation by using the finite difference estimate of volumetric heat capacity.

TODO:

Add a switch to use the temperature form of the heat equation;
Show results from science testing.

martynpclark commented 3 years ago

3sisters2shipsProw

martynpclark commented 1 year ago

Part of the SUNDIALS merge