Aquifer option `bigBucket` is not yet implemented for groundwater decision `singleBasin` - Githubissues

CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:

http://www.ral.ucar.edu/projects/summa

GNU General Public License v3.0

79 stars 103 forks source link

Aquifer option `bigBucket` is not yet implemented for groundwater decision `singleBasin` #500

Open wknoben opened 2 years ago

wknoben commented 2 years ago

Feature Requests

Description of feature Functional aquifer option for groundwater decision singleBasin.
Description of the problem the feature addresses This modeling option seems planned development but hasn't been included yet.

See: https://github.com/CH-Earth/summa/blob/372c3fbeb3825e3b3d635461a8e552f9f0895aec/build/source/engine/run_oneGRU.f90#L265

 ! compute water balance for the basin aquifer
 if(model_decisions(iLookDECISIONS%spatial_gw)%iDecision == singleBasin)then
  message=trim(message)//'multi_driver/bigBucket groundwater code not transferred from old code base yet'
  err=20; return
 end if

Will the proposed feature be backward compatible? Yes, this only adds functionality.
Will the proposed feature change the science results of SUMMA? No existing results will change. New results will be made possible.

wknoben commented 2 years ago

Further note: when this is addressed this check in coupled_em will need to be updated too:

https://github.com/CH-Earth/summa/blob/372c3fbeb3825e3b3d635461a8e552f9f0895aec/build/source/engine/coupled_em.f90#L246