Atmospheric Stability formula correction for `standard` method

CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:

http://www.ral.ucar.edu/projects/summa

GNU General Public License v3.0

80 stars 106 forks source link

Atmospheric Stability formula correction for `standard` method #521

Closed iamtekson closed 1 year ago

iamtekson commented 1 year ago

Make sure all the relevant boxes are checked (and only check the box if you actually completed the step):

[ ] Closes #xxx (identify the issue associated with this PR)
[x] Code passes standard test cases (results are either bit-for-bit identical, or differences are explained in the PR comment)
[ ] New tests added (describe which tests were performed to test the changes)
[ ] Science test figures (add figures to PR comment and describe the tests)
[x] Checked that the new code conforms to the SUMMA coding conventions
[x] Describe the change in the release notes (use either ./summa/docs/whats-new.md or ./summa/docs/minor-changes.md depending on what changed)

I got stabality correction formula as below in the Anderson (1976) paper.

wknoben commented 1 year ago

Hi, thanks for the PR!

Can I please ask you to update the following?

We typically don't merge directly into master. Instead, new changes are based on and merged into the develop branch. When enough changes accumulate there we move them into a new stable release on the master branch (see: https://summa.readthedocs.io/en/latest/development/SUMMA_git_workflow/). Could you re-open this PR using develop as the base and target branch?
I assume there was a reason why you started digging into this in the first place and it would be good to know what that reason was. Could you add a brief description (possibly including a plot) that shows what results you got before the fix and why that seemed wrong to you?

iamtekson commented 1 year ago

Hi @wknoben, I was working on a Capstone project from GEOG 825 course. We are doing sensitivity analysis testing using SUMMA software. While I was writing the report, I was comparing the flux equation on SUMMA implementation as well as on the actual paper. I found the stability correction formula for stable method different in Anderson (1976) paper and tried to modify it. But when I discuss with Dr. Clark, he said that, most of the equations were taken from Choudhury and Monteith (1988).

I think if that was the case, I only suggest you to change the comment and link the associate paper in this method. For now, you can close this PR without merging it.

PS: In atmospheric correction, I found sensitivity of the standard method relatively very sensitive to other method.

wknoben commented 1 year ago

Hi Tek, Thanks for the clarification. I'll close this but have recorded the request for clearer comments in #522