andywood
commented
9 months ago Great. This has been an outstanding issue since the start of summa. I think the existence of ds was a convenience for certain plotting routines, but is redundant and needlessly complicates the forcing files, as it can be directly assigned (no inference needed) from the forcing timestamp. I wrote code years ago to do this but it got lost in some reorganized/split PRs. Don't add a control file setting (again, redundant) -- infer from the forcing files, which is naturally backward compatible. Defined timestep may also be in the initial state files, but is more complicated to remove given how early they're read. Next target, perhaps. Thanks, I'm very glad to see it dealt with.
On Mon, Feb 12, 2024 at 2:42 PM Shervan Gharari @.***> wrote:
Feature Requests
- Removal of ds or time step of the forcing (in second) from the forcing file.
- Currently, the ds should be added to forcing files. Removal of ds and adding it to the control file or inferring it internally will reduce the workflow to prepare the forcing for SUMMA.
- Will the proposed feature be backward compatible? (1) Earlier setup should not fail if variable ds is inferred by SUMMA internally. (2) However, if implemented in the control file, the time step should be added to an existing setup.
- Will the proposed feature change the science results of SUMMA? No, it reduces the workflow to prepare the forcing files.
- The inference of ds is done internally for cesm-coupling branch of mizuRoute in the standalone folder in case that is helpful. Thank you in advance and let me know if I can assist in any form.
— Reply to this email directly, view it on GitHub https://github.com/CH-Earth/summa/issues/556, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIKARNBKRCVV2NJG24GF23YTKEFPAVCNFSM6AAAAABDFN42JOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZTCMBTGQ3DCNY . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Feature Requests
dsor time step of the forcing (in second) from the forcing file.dsshould be added to forcing files. Removal ofdsand adding it to the control file or inferring it internally will reduce the workflow to prepare the forcing for SUMMA.dsis inferred by SUMMA internally. (2) However, if implemented in the control file, the time step should be added to an existing setup.dsis done internally forcesm-couplingbranch ofmizuRoutein thestandalonefolder in case that is helpful. Thank you in advance and let me know if I can assist in any form.